Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[patch] bugfix lb-gateway's Insert rpc nil pointer panic #980

Merged
merged 5 commits into from
Feb 4, 2021
Merged

[patch] bugfix lb-gateway's Insert rpc nil pointer panic #980

merged 5 commits into from
Feb 4, 2021

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Feb 3, 2021

Signed-off-by: kpango kpango@vdaas.org

Description:

bugfix, gateway panics when user didn't send request config.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.15.7
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.13.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Feb 3, 2021

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@kpango kpango force-pushed the bugfix/lb-gateway/insert-handler-nil-pointer-panic branch from 7b8e222 to 37d2d6b Compare February 3, 2021 21:01
@github-actions github-actions bot added size/L and removed size/M labels Feb 3, 2021
@codecov
Copy link

codecov bot commented Feb 3, 2021 •
edited
Loading

Codecov Report

Merging #980 (9e71269) into master (9c405ba) will increase coverage by 0.10%.
The diff coverage is 4.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #980      +/-   ##
==========================================
+ Coverage   14.43%   14.53%   +0.10%     
==========================================
  Files         492      493       +1     
  Lines       27843    27967     +124     
==========================================
+ Hits         4019     4065      +46     
- Misses      23585    23661      +76     
- Partials      239      241       +2
Impacted Files Coverage Δ
pkg/gateway/backup/handler/grpc/handler.go 0.00% <0.00%> (ø)
pkg/gateway/filter/handler/grpc/handler.go 0.00% <0.00%> (ø)
pkg/gateway/lb/handler/grpc/handler.go 0.00% <0.00%> (ø)
pkg/gateway/meta/handler/grpc/handler.go 0.00% <0.00%> (ø)
internal/safety/safety.go 95.65% <100.00%> (+0.19%) ⬆️
internal/worker/worker.go 82.29% <0.00%> (-1.05%) ⬇️
internal/net/net.go 73.77% <0.00%> (ø)
internal/worker/queue.go 100.00% <0.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c405ba...9e71269. Read the comment docs.

@kpango kpango requested a review from rinx February 4, 2021 01:40
@kpango
[patch] bugfix lb-gateway's Insert rpc nil pointer panic
506185e 
Signed-off-by: kpango <kpango@vdaas.org>
@kpango kpango force-pushed the bugfix/lb-gateway/insert-handler-nil-pointer-panic branch from 37d2d6b to 506185e Compare February 4, 2021 02:01
@kpango
fix
8df8378 
Signed-off-by: kpango <kpango@vdaas.org>
@kpango
Copy link
Collaborator Author

kpango commented Feb 4, 2021

@rinx Thank you for review, I resolved all suggestion.

rinx
rinx reviewed Feb 4, 2021
View reviewed changes
internal/safety/safety.go Outdated Show resolved Hide resolved
kpango and others added 2 commits February 4, 2021 11:39
@kpango @rinx
Update internal/safety/safety.go
aa45f97 
Co-authored-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@kpango
Merge branch 'master' into bugfix/lb-gateway/insert-handler-nil-point…
b4d44d3 
…er-panic
rinx
rinx reviewed Feb 4, 2021
View reviewed changes
internal/safety/safety.go Outdated Show resolved Hide resolved
@kpango @rinx
Update internal/safety/safety.go
9e71269 
Co-authored-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx
Copy link
Contributor

rinx commented Feb 4, 2021

Maybe others okay.

@kpango
Copy link
Collaborator Author

kpango commented Feb 4, 2021

I'm going to merge & release this PR after all build succeed.

github-actions[bot]
github-actions bot reviewed Feb 4, 2021
View reviewed changes
pkg/gateway/filter/handler/grpc/handler.go Show resolved Hide resolved
pkg/gateway/filter/handler/grpc/handler.go Show resolved Hide resolved
pkg/gateway/filter/handler/grpc/handler.go Show resolved Hide resolved
internal/safety/safety.go Outdated Show resolved Hide resolved
pkg/gateway/lb/handler/grpc/handler.go Show resolved Hide resolved
@kpango kpango merged commit 9c8cace into master Feb 4, 2021
@kpango kpango deleted the bugfix/lb-gateway/insert-handler-nil-pointer-panic branch February 4, 2021 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@rinx rinx rinx left review comments

Assignees
No one assigned
Labels
area/gateway/backup area/gateway/filter area/gateway/lb area/gateway/meta area/internal priority/medium size/L type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpango @vdaas-ci @rinx